[PATCH 1/7] d2d1: Silence SetSegmentFlags() FIXME when setting default value.

Henri Verbeet hverbeet at codeweavers.com
Tue Jan 11 09:28:12 CST 2022


From: Stefan Brüns <stefan.bruens at rwth-aachen.de>

Some software (Buhl Tax and variants) repeatedly calls SetSegmentFlags()
with D2D1_PATH_SEGMENT_NONE, which is just the default value and has no
effect (unless the flags where already changed, which still reports
a FIXME).

Signed-off-by: Stefan Brüns <stefan.bruens at rwth-aachen.de>
Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
---
This supersedes patch 223231.
v3: Use the same scheme we use elsewhere.

 dlls/d2d1/geometry.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/dlls/d2d1/geometry.c b/dlls/d2d1/geometry.c
index a7074899fda..28414d7c9a9 100644
--- a/dlls/d2d1/geometry.c
+++ b/dlls/d2d1/geometry.c
@@ -2773,7 +2773,10 @@ static void STDMETHODCALLTYPE d2d_geometry_sink_SetFillMode(ID2D1GeometrySink *i
 
 static void STDMETHODCALLTYPE d2d_geometry_sink_SetSegmentFlags(ID2D1GeometrySink *iface, D2D1_PATH_SEGMENT flags)
 {
-    FIXME("iface %p, flags %#x stub!\n", iface, flags);
+    TRACE("iface %p, flags %#x.\n", iface, flags);
+
+    if (flags != D2D1_PATH_SEGMENT_NONE)
+        FIXME("Ignoring flags %#x.\n", flags);
 }
 
 static void STDMETHODCALLTYPE d2d_geometry_sink_BeginFigure(ID2D1GeometrySink *iface,
-- 
2.30.2




More information about the wine-devel mailing list