[PATCH vkd3d 3/5] vkd3d: Handle depth/stencil planes in GetCopyableFootprints().

Henri Verbeet hverbeet at gmail.com
Thu Jan 13 10:19:33 CST 2022


On Mon, 10 Jan 2022 at 15:02, Conor McCarthy <cmccarthy at codeweavers.com> wrote:
> diff --git a/tests/d3d12.c b/tests/d3d12.c
> index ee000b0b..b973ad9c 100644
> --- a/tests/d3d12.c
> +++ b/tests/d3d12.c
> @@ -19550,11 +19550,9 @@ static void test_get_copyable_footprints(void)
>                  sub_resource_count *= resource_desc.DepthOrArraySize;
>              if (resource_desc.Format == DXGI_FORMAT_D24_UNORM_S8_UINT)
>              {
> +                /* FIXME: we require D3D12_RESOURCE_FLAG_ALLOW_DEPTH_STENCIL here for DS formats but windows doesn't. */
>                  if (!vkd3d_test_platform_is_windows())
> -                {
> -                    skip("Depth/stencil planes are not supported.\n");
> -                    continue;
> -                }
> +                    resource_desc.Flags |= D3D12_RESOURCE_FLAG_ALLOW_DEPTH_STENCIL;
>                  sub_resource_count *= 2;
Arguably, the vkd3d_test_platform_is_windows() test here just makes
the test behaviour diverge between Windows and vkd3d; adding
D3D12_RESOURCE_FLAG_ALLOW_DEPTH_STENCIL should work on Windows as
well, right?



More information about the wine-devel mailing list