[PATCH v5 2/6] ddraw: Use WINED3D_SWAPCHAIN_NO_WINDOW_CHANGES also if DDSCL_NOWINDOWCHANGES is set.

Stefan Dösinger stefandoesinger at gmail.com
Thu Jan 13 11:34:29 CST 2022



> Am 13.01.2022 um 19:35 schrieb Gabriel Ivăncescu <gabrielopcode at gmail.com>:
> 
> If you think some tests are redundant or too overkill, I'll happily remove them (or, if you have suggestions to add even more...).

Nah, I think they are OK as is. ddraw is a pain, it won't get any easier, I'm just trying to make sure I don't sign off on something I don't understand myself

> Also I'll fix the dumb window2 leak, sorry. Let me know if there's anything else though, before I resend (but probably will do tomorrow).

Nothing so far at least for patches 1 to 3. I can't rule out something won't pop into my mind after another re-read, but right now, with the window2 leak fixed, you have my signed-off-by.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20220113/4b543e72/attachment.sig>


More information about the wine-devel mailing list