[PATCH v6 3/6] ddraw: Remove topmost style when going from exclusive mode to normal.

Stefan Dösinger stefandoesinger at gmail.com
Tue Jan 18 04:20:46 CST 2022


Am Dienstag, 18. Jänner 2022, 13:10:07 EAT schrieb Stefan Dösinger:
> Am Freitag, 14. Jänner 2022, 17:53:48 EAT schrieben Sie:
> > Interesting catch, but I can't seem to test it. Whenever I try to change
> > windows from exclusive I get DDERR_HWNDALREADYSET on native. I tried to
> > look at some place where this is done in current tests and couldn't
> > really find it, which has me wonder how the "window !=
> > ddraw->dest_window" was tested / can be reached in the first place?
> 
> Hmm, reading the tests the switch-between-windows test also switches between
> exclusive and non-exclusive mode at the same time. (ddraw7.c, 3480, "If the
> window is changed at the same time, messages are sent to the new window.")
> . I guess it is an academic difference then.

And I have another thought: Maybe add a comment in the code that checking for 
DDSCL_NOWINDOWCHANGES in cooplevel (new flags) and not ddraw->cooperative_level 
(old flags) is intentional and not a bug.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20220118/f6f79aea/attachment.sig>


More information about the wine-devel mailing list