[PATCH 2/2] ddraw/tests: Prefer D24S8 over D24X8.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=105683

Your paranoid android.


=== w8adm (32 bit report) ===

ddraw:
ddraw7.c:4651: Test failed: Lit quad without normals has color 0x00ff0000, expected 0x00000000.
ddraw7.c:4664: Test failed: Lit quad with normals has color 0x00ff0000, expected 0x00000000.
ddraw7.c:4709: Test failed: Lit quad with non-affine matrix has color 0x00ff0000.

=== w1064v1809 (32 bit report) ===

ddraw:
ddraw7.c:18861: Test failed: Got unexpected color 0x00000040.

=== debian11 (32 bit report) ===

ddraw:
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.
ddraw7.c:2628: Test failed: Expected window style 0x4cf0000, got 0xa40b0000.
ddraw7.c:2661: Test failed: Expected window style 0x4cf0000, got 0xa40b0000.
ddraw7.c:2664: Test failed: Expected window extended style 0x108, got 0x8.
ddraw7.c:2670: Test failed: Expected window style 0x4cf0000, got 0xa40b0000.
ddraw7.c:2673: Test failed: Expected window extended style 0x108, got 0x8.
ddraw7.c:2693: Test failed: Expected window style 0x4cf0000, got 0xa40b0000.
ddraw7.c:2695: Test failed: Expected window extended style 0x100, got 0.
ddraw7.c:2712: Test failed: Expected (0,0)-(640,480), got (-32000,-32000)-(-31840,-31976).
ddraw7.c:2735: Test failed: Expected (0,0)-(640,480), got (-32000,-32000)-(-31840,-31976).
ddraw7.c:2755: Test failed: Expected window style 0x4cf0000, got 0xa40b0000.
ddraw7.c:2757: Test failed: Expected window extended style 0x100, got 0.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.

=== debian11 (32 bit Arabic:Morocco report) ===

ddraw:
ddraw4.c:3530: Test failed: Expected message 0x47, but didn't receive it.
ddraw4.c:3532: Test failed: Expected screen size 640x480, got 0x0.
ddraw4.c:3538: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3562: Test failed: Expected surface width 640, got 720.
ddraw4.c:3568: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3575: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3580: Test failed: Expected surface width 640, got 720.
ddraw4.c:3595: Test failed: Expected surface width 640, got 720.
ddraw4.c:3601: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3624: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3637: Test failed: Got unexpected hr 0.
ddraw4.c:3639: Test failed: Got unexpected hr 0.
ddraw4.c:3646: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3651: Test failed: Expected surface width 640, got 720.
ddraw4.c:3672: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3692: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3705: Test failed: Expected resolution 640x480, got 720x480.
ddraw4.c:3722: Test failed: Expected surface width 640, got 720.
ddraw4.c:3728: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3738: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3743: Test failed: Expected surface width 640, got 720.
ddraw4.c:3758: Test failed: Expected surface width 640, got 720.
ddraw4.c:3764: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3787: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3800: Test failed: Got unexpected hr 0.
ddraw4.c:3802: Test failed: Got unexpected hr 0.
ddraw4.c:3809: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3814: Test failed: Expected surface width 640, got 720.
ddraw4.c:3835: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3855: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3868: Test failed: Expected resolution 640x480, got 720x480.
ddraw4.c:3885: Test failed: Expected surface width 640, got 720.
ddraw4.c:3892: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3909: Test failed: Expected message 0x5, but didn't receive it.
ddraw4.c:3911: Test failed: Expected screen size 640x480, got 0x0.
ddraw4.c:3918: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:3930: Test failed: Expected surface width 640, got 720.
ddraw4.c:3983: Test failed: Expected screen size 2 640x480, got 720x480.
ddraw4.c:3991: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480).
ddraw4.c:4003: Test failed: Expected surface width 640, got 720.
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.

=== debian11 (32 bit German report) ===

ddraw:
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.
ddraw4.c:18323: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768).
ddraw4.c:18379: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768).
ddraw4.c:18386: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768).
ddraw4.c:18323: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,737).
ddraw4.c:18345: Test failed: Expected window rect (800,0)-(1824,737), got (0,0)-(1024,737).
ddraw4.c:18360: Test failed: Expected window rect (800,0)-(1824,737), got (0,0)-(1024,737).
ddraw4.c:18379: Test failed: Expect window rect (0,0)-(800,600), got (1024,0)-(2048,737).
ddraw4.c:18386: Test failed: Expect window rect (0,0)-(800,600), got (1024,0)-(2048,737).
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.

=== debian11 (32 bit French report) ===

ddraw:
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.

=== debian11 (32 bit Hebrew:Israel report) ===

ddraw:
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.

=== debian11 (32 bit Hindi:India report) ===

ddraw:
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.

=== debian11 (32 bit Japanese:Japan report) ===

ddraw:
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.

=== debian11 (32 bit Chinese:China report) ===

ddraw:
ddraw4.c:4217: Test failed: Got unexpected screen width 800.
ddraw4.c:4219: Test failed: Got unexpected screen height 600.
ddraw4.c:4241: Test failed: Got unexpected screen width 800.
ddraw4.c:4243: Test failed: Got unexpected screen height 600.
ddraw4.c:4276: Test failed: Got unexpected screen width 800.
ddraw4.c:4278: Test failed: Got unexpected screen height 600.
ddraw4.c:4299: Test failed: Got unexpected screen width 800.
ddraw4.c:4301: Test failed: Got unexpected screen height 600.
ddraw4.c:4306: Test failed: Got unexpected screen width 800.
ddraw4.c:4308: Test failed: Got unexpected screen height 600.
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.

=== debian11 (32 bit WoW report) ===

ddraw:
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.

=== debian11 (64 bit WoW report) ===

ddraw:
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw4.c:11666: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw4.c:11710: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.
ddraw7.c:3958: Test failed: Got unexpected screen width 640.
ddraw7.c:3960: Test failed: Got unexpected screen height 480.
ddraw7.c:3965: Test failed: Got unexpected screen width 640.
ddraw7.c:3967: Test failed: Got unexpected screen height 480.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface vidmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface vidmem zbuffer.
ddraw7.c:11650: Test failed: Got clear result 0x00beef00, expected 0x00adbeef, surface sysmem zbuffer.
ddraw7.c:11694: Test failed: Got clear result 0xffffff00, expected 0xffffffff, surface sysmem zbuffer.