[PATCH] Use Windows 10 as default prefix version.

Alexandre Julliard julliard at winehq.org
Mon Jan 24 05:51:35 CST 2022


Nikolay Sivov <nsivov at codeweavers.com> writes:

> On 1/21/22 18:11, Paul Gofman wrote:
>> There is also version number in kernel32/version.rc which some games
>> expect to have in sync IIRC.
>
> No reason we shouldn't have it in sync, but on Windows apparently it's
> possible to have it slightly off comparing to build value in registry.
>
>>
>> Then, there is a version number hardcoded in
>> kernelbase/version.c:version_data[] which is currently 17134, that 
>> should probably be bumped as well? (fwiw there is also the number in
>> ntdll/version.c: VersionData[] but this is 17763 now.
>
> See attached v2 patch as an attempt to unify this. Symbol name should
> probably be WIN10BUILDNUMBER, in case major number will be ever bumped 
> from 10.
>
> Alexandre, what do you think?

I don't think we're going to have to change it often enough to add a
header just for this. Hardcoding it in a few places is fine, though I'd
suggest to use decimal everywhere to make it easier to grep for.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list