[PATCH vkd3d 2/6] tests: Test a number of simple HLSL operations.

Giovanni Mascellani gmascellani at codeweavers.com
Tue Jan 25 14:17:56 CST 2022


Hi,

Il 25/01/22 19:59, Zebediah Figura (she/her) ha scritto:
> I don't really like this approach. For one thing, it makes it harder to 
> validate e.g. patches 4-6 from this series (I essentially have to write 
> my own shaders).
> 
> The complexity of the generated shader also makes it harder to read the 
> IR to validate it's doing the right thing.
> 
> Perhaps more importantly, some of these operations are supported by all 
> HLSL versions, but some are only supported by SM4 (notably integer 
> operations). Anything that can be tested in sm2 or sm3 should be, and as 
> such I'd appreciate splitting those out where possible.

Would it be better if I splitted this into many little shaders in the 
same .shader_test file, like I already did for hlsl-shape.shader_test?

Also, is there a difference with 1/6 with this respect, since you signed 
off on that one?

Giovanni.



More information about the wine-devel mailing list