[PATCH 1/4] dmusic: Implement the E_NOTIMPL methods of the synth port

Michael Stefaniuc mstefani at winehq.org
Tue Jan 25 16:11:23 CST 2022


Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
---
 dlls/dmusic/port.c | 21 ++++++---------------
 1 file changed, 6 insertions(+), 15 deletions(-)

diff --git a/dlls/dmusic/port.c b/dlls/dmusic/port.c
index 7fe72563bb0..490ff88059e 100644
--- a/dlls/dmusic/port.c
+++ b/dlls/dmusic/port.c
@@ -240,20 +240,14 @@ static HRESULT WINAPI synth_port_PlayBuffer(IDirectMusicPort *iface, IDirectMusi
 
 static HRESULT WINAPI synth_port_SetReadNotificationHandle(IDirectMusicPort *iface, HANDLE event)
 {
-    struct synth_port *This = synth_from_IDirectMusicPort(iface);
-
-    FIXME("(%p/%p)->(%p): stub\n", iface, This, event);
-
-    return S_OK;
+    TRACE("(%p, %p): method not implemented\n", iface, event);
+    return E_NOTIMPL;
 }
 
 static HRESULT WINAPI synth_port_Read(IDirectMusicPort *iface, IDirectMusicBuffer *buffer)
 {
-    struct synth_port *This = synth_from_IDirectMusicPort(iface);
-
-    FIXME("(%p/%p)->(%p): stub\n", iface, This, buffer);
-
-    return S_OK;
+    TRACE("(%p, %p): method not implemented\n", iface, buffer);
+    return E_NOTIMPL;
 }
 
 static HRESULT WINAPI synth_port_DownloadInstrument(IDirectMusicPort *iface, IDirectMusicInstrument *instrument,
@@ -384,11 +378,8 @@ static HRESULT WINAPI synth_port_GetRunningStats(IDirectMusicPort *iface, DMUS_S
 
 static HRESULT WINAPI synth_port_Compact(IDirectMusicPort *iface)
 {
-    struct synth_port *This = synth_from_IDirectMusicPort(iface);
-
-    FIXME("(%p/%p)->(): stub\n", iface, This);
-
-    return S_OK;
+    TRACE("(%p): method not implemented\n", iface);
+    return E_NOTIMPL;
 }
 
 static HRESULT WINAPI synth_port_GetCaps(IDirectMusicPort *iface, DMUS_PORTCAPS *port_caps)
-- 
2.34.1




More information about the wine-devel mailing list