[PATCH vkd3d v4 1/6] tests: Test matrix multiplication.

Giovanni Mascellani gmascellani at codeweavers.com
Fri Jan 28 09:33:09 CST 2022


Hi,

Il 28/01/22 14:35, Francisco Casas ha scritto:
> It seems that mul checks whether it is a scalar-scalar, scalar-vector,
> scalar-matrix, vector-scalar, vector-vector, vector-matrix, matrix-scalar,
> matrix-vector, or matrix-matrix multiplication, using the equivalent to our
> hlsl_type_class.
> 
> This difference makes me wonder whether we are wrong assuming float and float1
> are the same in other parts of the codebase, for instance:

As you say float and float1 are two different things in HLSL, but once 
we are deep enough in the pipeline that all the relevant operations 
(like mul()) have been lowered, then we can ignore the difference. As (I 
think) I have said in another email, what I would like to happen is that 
at some point everything is converted to vectors (so we don't have 
scalars lingering around anymore), but it doesn't seem that the others 
agree with me.

Giovanni.



More information about the wine-devel mailing list