[PATCH v4 1/4] wdscore: Implement CurrentIP.

Mohamad Al-Jaf mohamadaljaf at gmail.com
Mon Jan 31 03:18:32 CST 2022


Hi,

> Every process has its own virtual address space (VAS) [1].

Thanks for the detailed explanation and also for the references. I didn't
know about Windows Internals, seems like a good book to learn about how
Windows works, much appreciated.

> Since it has no arguments and is not a "public" exported function it
> probably does not matter. But yes, using __ASM_STDCALL_FUNC without
> declaring it as WINAPI is a mismatch. You should be using either
> __ASM_GLOBAL_FUNC and no WINAPI, or __ASM_STDCALL_FUNC with WINAPI.
>
> I guess if the header doesn't use WINAPI, might as well make it without.

Yeah, I don't think it really matters. But I just want it to be as accurate
as possible to the Windows implementation. Thank you for the clarification,
I wasn't sure what to do.

> I mostly agree and tried here to interpret Dmitry's statement.

I see, yeah, I also agree that it's not necessary.

I've submitted a revision.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20220131/d4e97801/attachment.htm>


More information about the wine-devel mailing list