[PATCH 09/14] dlls/gdi32: use correct integral type

Jacek Caban jacek at codeweavers.com
Mon Jan 31 10:34:03 CST 2022


On 1/31/22 14:44, Eric Pouech wrote:
> Le 31/01/2022 à 14:24, Nikolay Sivov a écrit :
>> Maybe we could adjust NtGdi prototypes instead. I see a number of 
>> casts like that in existing code already, that would be unnecessary 
>> if DWORD was used for the prototype.
>>
> I'm in for avoiding the casts !
>
> but, these APIs are not documented on MS web servers
>
> and I don't have a ddk handy to check the prototypes
>
> reactos and drmemory both define ntgdipolypolydraw with a PULONG 
> instead, which could be a hint, not an absolute confirmation though
>

I think that, since it's not documented anyway, we may pick the type 
that works best, as long as it's binary compatible. Note that some 
callers already have casts, because it's sometimes used on INT*, 
sometimes on DWORD*, depending on the function. We could avoid new casts 
by simply using DWORD or ULONG for NtGdiPolyPolyDraw.


Thanks,

Jacek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20220131/4fa2d42b/attachment.htm>


More information about the wine-devel mailing list