[PATCH 0/5] MR355: win32u: Move more display mode logic out of graphics drivers.
Zhiyi Zhang (@zhiyi)
wine at gitlab.winehq.org
Fri Jul 1 02:54:27 CDT 2022
On Fri Jul 1 07:48:31 2022 +0000, Zhiyi Zhang wrote:
> Be very careful about dmDriverExtra. You are losing private driver data
> here. "memcpy(full_mode, found_mode, sizeof(*found_mode) +
> found_mode->dmDriverExtra)" is how full mode is populated.
Oh, this full mode is used for storing in the registry. So we don't need private data. But I think it's still best to dmDriverExtra to 0 after copying.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/355#note_3100
More information about the wine-devel
mailing list