[PATCH v4 0/3] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod

Claire (@ClearlyClaire) wine at gitlab.winehq.org
Mon Jul 4 05:17:14 CDT 2022


On Mon Jul  4 08:41:05 2022 +0000, Huw Davies wrote:
> The former.  Keep the first patch in the series, then add a
> `get_mix_format` unixcall that `GetMixFormat()` always calls and use
> `pulse_name` to determine the correct values in the unixlib.  Then do a
> similar thing for `GetDevicePeriod()`.
> Note, when you add or change a unixcall, you also need to add (or
> change) the appropriate wow64 handler (see e.g. `wow64_get_mix_format()`
> in the alsa driver.
I reordered `pulse_probe_settings`'s arguments as well as `get_device_settings_params` attributes to have inputs first and outputs last. I have also moved the `pulse_name[0]` checks to the unixlib, and made it fallback to the default settings if the device could not be found. I have added the missing wow64 handler, though I am not 100% sure it is correct as I am not familiar with it.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/337#note_3193



More information about the wine-devel mailing list