[PATCH v8 0/4] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod

Claire (@ClearlyClaire) wine at gitlab.winehq.org
Mon Jul 4 14:04:05 CDT 2022


On Mon Jul  4 18:50:19 2022 +0000, Claire wrote:
> Seems to be caused by allowing comparisons to a blank (`pulse_name[0] ==
> 0`), I'm not completely sure why that would be an issue, especially with
> `pulse_get_prop_value` not doing that kind of test either, but adding
> the test fixes it, so I'll re-submit patches with this additional check. Sorry.
Actually figured it out, `min_period` and `def_period` weren't set unconditionally, but after a comparison to their previous (uninitialized) value. Fixed it by initializing them to 0.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/337#note_3269



More information about the wine-devel mailing list