[PATCH v4 4/6] winegstreamer: Implement IWMOutputMediaProps_SetMediaType.
Zebediah Figura
zfigura at codeweavers.com
Mon Jul 4 15:26:33 CDT 2022
On 6/15/22 01:58, Rémi Bernon wrote:
> From: Rémi Bernon <rbernon at codeweavers.com>
>
> Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
> ---
> dlls/winegstreamer/wm_reader.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/winegstreamer/wm_reader.c b/dlls/winegstreamer/wm_reader.c
> index 03adea8a318..a235f2d15c6 100644
> --- a/dlls/winegstreamer/wm_reader.c
> +++ b/dlls/winegstreamer/wm_reader.c
> @@ -116,8 +116,12 @@ static HRESULT WINAPI output_props_GetMediaType(IWMOutputMediaProps *iface, WM_M
>
> static HRESULT WINAPI output_props_SetMediaType(IWMOutputMediaProps *iface, WM_MEDIA_TYPE *mt)
> {
> - FIXME("iface %p, mt %p, stub!\n", iface, mt);
> - return E_NOTIMPL;
> + const struct output_props *props = impl_from_IWMOutputMediaProps(iface);
> +
> + TRACE("iface %p, mt %p.\n", iface, mt);
> +
> + FreeMediaType((AM_MEDIA_TYPE *)&props->mt);
> + return CopyMediaType((AM_MEDIA_TYPE *)&props->mt, (AM_MEDIA_TYPE *)mt);
> }
>
> static HRESULT WINAPI output_props_GetStreamGroupName(IWMOutputMediaProps *iface, WCHAR *name, WORD *len)
I think this deserves tests. The lack of media type validation in
particular is concerning.
More information about the wine-devel
mailing list