[PATCH vkd3d 5/5] tests: Test arithmetic int operations without constant operands.

Zebediah Figura zfigura at codeweavers.com
Mon Jul 4 15:30:19 CDT 2022


On 7/1/22 03:25, Giovanni Mascellani wrote:
> Hi,
> 
> Il 01/07/22 06:43, Zebediah Figura ha scritto:
>> Passing "uniform int" requires sm4 (well, sort of), but the actual
>> operations should be possible with sm1. Perhaps pass the inputs as
>> floats and then cast them to int variables before performing arithmetic?
> 
> The main point of that test is to run the code that does some int
> operation lowering (division, modulus and absolute value; well, there is
> not absolute value, I'll add it), patches still to be contributed. SM4
> doesn't represent those operations directly and rather requires some
> more complicated code to emulate them. I guess this doesn't happen in
> SM1, given that those operations are silently converted to float anyway,
> so I didn't consider it a priority anyway. But I can do what you suggested.

Right, underlyingly what's being tested is going to be different. But 
eventually I imagine we'll want *some* manner of tests for int 
instructions in sm1, so it probably makes sense to reuse these. 
(Assuming they behave sanely, that is. No need to bend over backwards to 
accommodate both sm1 and sm4 in the same test unit.)



More information about the wine-devel mailing list