[PATCH 1/5] d2d1/tests: Add missing return value check (Coverity).

Nikolay Sivov wine at gitlab.winehq.org
Tue Jul 5 01:31:27 CDT 2022


From: Nikolay Sivov <nsivov at codeweavers.com>

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
 dlls/d2d1/tests/d2d1.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/dlls/d2d1/tests/d2d1.c b/dlls/d2d1/tests/d2d1.c
index 334e9f1adea..fed0e9bdf96 100644
--- a/dlls/d2d1/tests/d2d1.c
+++ b/dlls/d2d1/tests/d2d1.c
@@ -10934,7 +10934,11 @@ static void test_effect_register(BOOL d3d11)
         hr = ID2D1Factory1_RegisterEffectFromString(factory, &CLSID_TestEffect,
                 test->effect_xml, test->binding, test->binding_count, effect_impl_create);
         ok(hr == test->hr, "Got unexpected hr %#lx, expected %#lx.\n", hr, test->hr);
-        ID2D1Factory1_UnregisterEffect(factory, &CLSID_TestEffect);
+        if (SUCCEEDED(hr))
+        {
+            hr = ID2D1Factory1_UnregisterEffect(factory, &CLSID_TestEffect);
+            ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
+        }
 
         winetest_pop_context();
     }
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/377



More information about the wine-devel mailing list