[PATCH 0/7] MR374: win32u: scroll conversion

Huw Davies (@huw) wine at gitlab.winehq.org
Tue Jul 5 02:06:37 CDT 2022


Huw Davies (@huw) commented about dlls/user32/scroll.c:
>   */
> -BOOL WINAPI DECLSPEC_HOTPATCH GetScrollRange(HWND hwnd, INT nBar, LPINT lpMin, LPINT lpMax)
> +BOOL WINAPI DECLSPEC_HOTPATCH GetScrollRange( HWND hwnd, int bar, int *min, int *max )
>  {
> -    TRACE("hwnd=%p nBar=%d lpMin=%p lpMax=%p\n", hwnd, nBar, lpMin, lpMax);
> +    SCROLLINFO info;
> +
> +    TRACE( "hwnd=%p nBar=%d lpMin=%p lpMax=%p\n", hwnd, bar, min, max );
>  
>      /* Refer SB_CTL requests to the window */
> -    if (nBar == SB_CTL)
> -        SendMessageW(hwnd, SBM_GETRANGE, (WPARAM)lpMin, (LPARAM)lpMax);
> -    else
> -        SCROLL_GetScrollRange(hwnd, nBar, lpMin, lpMax);
> +    if (bar == SB_CTL)
> +        return SendMessageW( hwnd, SBM_GETPOS, 0, 0 );
This looks like a copy-and-paste error from the previous commit which explains the test failures.  I'll push a fix.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/374#note_3310



More information about the wine-devel mailing list