[PATCH v9 0/9] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod

[Huw Davies (@huw)]

Huw Davies (@huw) commented about dlls/winepulse.drv/pulse.c:
>          return STATUS_SUCCESS;
>      }
>  
> -    *params->fmt = pulse_fmt[params->flow == eCapture];
> -    params->result = S_OK;
> -
> +    params->result = E_FAIL;
>      return STATUS_SUCCESS;
>  }
>  
If we really don't need this, then don't add it in the earlier commit.  This also applies to the next commit.

A couple of other comments:

- Please use a capital letter to begin the commit msg (after the winepulse.drv: prefix).  The first few commits do this, but the last ones don't.
- Please keep the order of the unixcalls as consistent as possible to the other drivers.  So add `get_mix_format` after `release_capture_buffer` (there is no `is_format_supported`) and let's add `get_device_period` after `get_mix_format`.  This applies to the order of the unix_funcs, the definition of the params structs, and preferrably to the order of the funcs in `pulse.c`.  This will make it easier to compare implementations between the drivers.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/337#note_3325