[PATCH v2 5/6] mciqtz32: Update parent window's state instead of the video window's one.

Akihiro Sagawa wine at gitlab.winehq.org
Tue Jul 5 06:34:25 CDT 2022


From: Akihiro Sagawa <sagawa.aki at gmail.com>

Signed-off-by: Akihiro Sagawa <sagawa.aki at gmail.com>
---
 dlls/mciqtz32/mciqtz.c | 2 +-
 dlls/winmm/tests/mci.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/mciqtz32/mciqtz.c b/dlls/mciqtz32/mciqtz.c
index d8cc55ba2b9..e6ce2af59e8 100644
--- a/dlls/mciqtz32/mciqtz.c
+++ b/dlls/mciqtz32/mciqtz.c
@@ -1033,7 +1033,7 @@ static DWORD MCIQTZ_mciWindow(UINT wDevID, DWORD dwFlags, LPMCI_DGV_WINDOW_PARMS
     }
     if (dwFlags & MCI_DGV_WINDOW_STATE) {
         TRACE("Setting nCmdShow to %d\n", lpParms->nCmdShow);
-        IVideoWindow_put_WindowState(wma->vidwin, lpParms->nCmdShow);
+        ShowWindow(wma->parent, lpParms->nCmdShow);
     }
     if (dwFlags & MCI_DGV_WINDOW_TEXT) {
         TRACE("Setting caption to %s\n", debugstr_w(lpParms->lpstrText));
diff --git a/dlls/winmm/tests/mci.c b/dlls/winmm/tests/mci.c
index f123963d79a..16bdeacd6cc 100644
--- a/dlls/winmm/tests/mci.c
+++ b/dlls/winmm/tests/mci.c
@@ -1514,7 +1514,7 @@ static void test_video_window(HWND hwnd)
     parm.win.nCmdShow = SW_HIDE;
     err = mciSendCommandW(wDeviceID, MCI_WINDOW, MCI_DGV_WINDOW_STATE, (DWORD_PTR)&parm);
     ok(!err,"mciCommand window state returned %s\n", dbg_mcierr(err));
-    todo_wine ok(!IsWindowVisible(video_window), "video window (%p) should be hidden\n", video_window);
+    ok(!IsWindowVisible(video_window), "video window (%p) should be hidden\n", video_window);
 
     parm.win.hWnd = (HWND)0xdeadbeef;
     err = mciSendCommandW(wDeviceID, MCI_WINDOW, MCI_DGV_WINDOW_HWND, (DWORD_PTR)&parm);
@@ -1553,7 +1553,7 @@ static void test_video_window(HWND hwnd)
     parm.win.nCmdShow = SW_HIDE;
     err = mciSendCommandW(wDeviceID, MCI_WINDOW, MCI_DGV_WINDOW_STATE, (DWORD_PTR)&parm);
     ok(!err,"mciCommand window state returned %s\n", dbg_mcierr(err));
-    todo_wine ok(!IsWindowVisible(hwnd), "window (%p) should be hidden\n", hwnd);
+    ok(!IsWindowVisible(hwnd), "window (%p) should be hidden\n", hwnd);
 
     err = mciSendCommandW(wDeviceID, MCI_CLOSE, 0, 0);
     ok(!err,"mciCommand close returned %s\n", dbg_mcierr(err));
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/370



More information about the wine-devel mailing list