[PATCH v10 0/7] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod

Huw Davies (@huw) wine at gitlab.winehq.org
Tue Jul 5 08:47:44 CDT 2022


On Tue Jul  5 13:47:44 2022 +0000, Gabriel Ivăncescu wrote:
> One last thing I noticed: in pulse_probe_settings, since we're passing
> the empty string pulse_name now for the default device, you'll have to
> convert it to NULL before handling it off to the pulse API.
Oh yuck, that's fragile.

Right, so probably near the start of `pulse_probe_settings()` you want
```c
if (!pulse_name[0]) pulse_name = NULL;
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/337#note_3349



More information about the wine-devel mailing list