[PATCH v11 0/7] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod

[Claire (@ClearlyClaire)]

On Tue Jul  5 15:02:46 2022 +0000, Huw Davies wrote:
> ```suggestion:-4+0
>     if (FAILED(hr = get_device_period_helper(params->dataflow,
> params->pulse_name, &period, NULL)))
>         goto exit;
> ```
> But, there's an existing issue in the failure path under `exit:`
> (`free(stream)` should move out from the `if(stream->stream)` block).
>  So perhaps fix this issue in a separate commit before this one.
I am actually not sure `stream->local_buffer` is allocated by this point. I think it only gets initialized on line 1153, so going to `exit` would be incorrect. But if that's the case, the existing goto on line 1119 is incorrect too.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/337#note_3361