[tools] testbot/cgi: Highlight the name of the invalid field(s) on form errors.

Francois Gouget fgouget at codeweavers.com
Wed Jul 6 09:05:28 CDT 2022


Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/ObjectModel/CGI/FormPage.pm | 4 +++-
 testbot/web/WineTestBot.css             | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm
index f2fd0f09cd..67b3fa00d3 100644
--- a/testbot/lib/ObjectModel/CGI/FormPage.pm
+++ b/testbot/lib/ObjectModel/CGI/FormPage.pm
@@ -432,7 +432,9 @@ sub GenerateField($$$$)
 {
   my ($self, $PropertyDescriptor, $Display, $Format) = @_;
 
-  print "<div class='ItemProperty'><label>",
+  my $Class = $self->IsErrField($PropertyDescriptor->GetName()) ?
+              " class='errorfield'" : "";
+  print "<div class='ItemProperty'><label$Class>",
         $self->escapeHTML($self->GetDisplayName($PropertyDescriptor)),
         "</label>";
 
diff --git a/testbot/web/WineTestBot.css b/testbot/web/WineTestBot.css
index 78d33f886d..fd6acac86d 100644
--- a/testbot/web/WineTestBot.css
+++ b/testbot/web/WineTestBot.css
@@ -377,6 +377,7 @@ pre
    margin-bottom: 2em;
    background-color: red;
 }
+.errorfield  { color: red; }
 
 .right { float: right; }
 
-- 
2.30.2




More information about the wine-devel mailing list