[PATCH v2 0/4] MR375: ntdll: Fixes for runtime 64-bit shift functions.
Jinoh Kang (@iamahuman)
wine at gitlab.winehq.org
Wed Jul 6 10:50:55 CDT 2022
Jinoh Kang (@iamahuman) commented about dlls/ntdll/large_int.c:
> +
> /******************************************************************************
> * _allshl (NTDLL.@)
> - *
> - * Shift a 64 bit integer to the left.
> - *
> - * PARAMS
> - * a [I] Initial number.
> - * b [I] Number to shift a by to the left.
> - *
> - * RETURNS
> - * The left-shifted value.
> */
> -LONGLONG WINAPI _allshl( LONGLONG a, LONG b )
> +__ASM_GLOBAL_FUNC( _allshl,
> + "xchgl (%esp),%ecx\n\t"
Maybe a nit, and this pattern also resides in other preëxisting code already, but do we _really_ want to use a full memory barrier in such cases?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/375#note_3467
More information about the wine-devel
mailing list