[PATCH v3] sechost: Support decimal or octal access rights in ConvertStringSecurityDescriptorToSecurityDescriptor.

[Dmitry Timoshkov]

Zebediah Figura <zfigura at codeweavers.com> wrote:

> On 7/6/22 07:30, Dmitry Timoshkov wrote:
> > diff --git a/dlls/sechost/security.c b/dlls/sechost/security.c
> > index 6916b3ad662..8a8ca0f051a 100644
> > --- a/dlls/sechost/security.c
> > +++ b/dlls/sechost/security.c
> > @@ -903,6 +903,9 @@ static DWORD parse_ace_right( const WCHAR **string_ptr )
> >       if (string[0] == '0' && string[1] == 'x')
> >           return wcstoul( string, (WCHAR **)string_ptr, 16 );
> >   
> > +    if (iswdigit( string[0] ))
> > +        return wcstoul( string, (WCHAR **)string_ptr, 0 );
> > +
> >       for (i = 0; i < ARRAY_SIZE(ace_rights); ++i)
> >       {
> >           if (!wcsncmp( string, ace_rights[i].str, 2 ))
> 
> Doesn't that mean we can combine this with the hexadecimal case above?

I also had a temptation to merge both cases, however I decided to leave
them separate, preferring a separate patch if really necessary.

-- 
Dmitry.