[PATCH 0/3] MR395: win32u: Move reading and writing mode from registry out of graphics drivers.

Huw Davies (@huw) wine at gitlab.winehq.org
Thu Jul 7 02:37:19 CDT 2022


Huw Davies (@huw) commented about dlls/win32u/sysparams.c:
> +    if (!is_detached_mode( devmode ) && (!devmode->dmPelsWidth || !devmode->dmPelsHeight))
> +    {
> +        if (!current_mode->dmSize) return NULL;
> +        if (!devmode->dmPelsWidth) devmode->dmPelsWidth = current_mode->dmPelsWidth;
> +        if (!devmode->dmPelsHeight) devmode->dmPelsHeight = current_mode->dmPelsHeight;
> +    }
> +
> +    return devmode;
> +}
> +
>  /***********************************************************************
>   *	     NtUserChangeDisplaySettingsExW    (win32u.@)
>   */
>  LONG WINAPI NtUserChangeDisplaySettings( UNICODE_STRING *devname, DEVMODEW *devmode, HWND hwnd,
>                                           DWORD flags, void *lparam )
>  {
How about fixing the comment (i.e. remove the tailing "ExW") while we're making changes here?  I wouldn't have bothered pointing this out, but it'll give testbot another chance.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/395#note_3520



More information about the wine-devel mailing list