[PATCH v3 0/7] MR391: scrrun: Implement MoveFolder().

Akihiro Sagawa (@sgwaki) wine at gitlab.winehq.org
Thu Jul 7 10:26:36 CDT 2022


Akihiro Sagawa (@sgwaki) commented about dlls/scrrun/tests/filesystem.c:
> +
> +    ok(CreateDirectoryW(buffW1, NULL), "CreateDirectory(%s) failed\n", wine_dbgstr_w(buffW1));
> +    src = SysAllocString(buffW1);
> +    dst = SysAllocString(buffW2);
> +    hr = IFileSystem3_MoveFolder(fs3, src, dst);
> +    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> +    SysFreeString(src);
> +    SysFreeString(dst);
> +    ok(RemoveDirectoryW(buffW2), "can't remove %s directory\n", wine_dbgstr_w(buffW1));
> +
> +    str = SysAllocString(L"null.txt");
> +    hr = IFileSystem3_MoveFolder(fs3, str, NULL);
> +    ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr);
> +    hr = IFileSystem3_MoveFolder(fs3, NULL, str);
> +    ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr);
> +    SysFreeString(str);
How about to add `IFileSystem3_MoveFolder(fs3, "", str);` and  `IFileSystem3_MoveFolder(fs3, str, "");`?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/391#note_3548



More information about the wine-devel mailing list