[PATCH v2 2/2] qedit: Remove "ugly" work around

Brendan McGrath brendan at redmandi.com
Sat Jul 9 01:51:58 CDT 2022


This patch removes a work around that causes a crash in Unravel Two.

There is a callback in Unravel Two that appears to add a reference to a
IMediaSample, which this work around treats as a leak and releases. However, the
application also releases the reference causing a negative overflow and
an assertion failure on line 345 of dlls/quartz/memallocator.c.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51616
Signed-off-by: Brendan McGrath <brendan at redmandi.com>
---
 dlls/qedit/samplegrabber.c  | 3 ---
 dlls/qedit/tests/mediadet.c | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/dlls/qedit/samplegrabber.c b/dlls/qedit/samplegrabber.c
index 9b9780e564a8..cefb2f370785 100644
--- a/dlls/qedit/samplegrabber.c
+++ b/dlls/qedit/samplegrabber.c
@@ -164,9 +164,6 @@ static void SampleGrabber_callback(struct sample_grabber *This, IMediaSample *sa
 		if (ref)
 		{
 		    ERR("(%p) Callback referenced sample %p by %lu\n", This, sample, ref);
-		    /* ugly as hell but some apps are sooo buggy */
-		    while (ref--)
-			IMediaSample_Release(sample);
 		}
 	    }
             break;
diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c
index 3ea752176618..8026b37f53ef 100644
--- a/dlls/qedit/tests/mediadet.c
+++ b/dlls/qedit/tests/mediadet.c
@@ -1093,7 +1093,7 @@ static void test_samplegrabber(void)
 
     // Release the Ref we added in the callback
     refcount = IUnknown_Release(&my_sample.sample);
-    todo_wine ok(refcount == 0, "refcount should be zero\n");
+    ok(refcount == 0, "refcount should be zero\n");
 
     IMemInputPin_Release(inpin);
     IPin_Release(pin);
-- 
2.34.1




More information about the wine-devel mailing list