[PATCH vkd3d 09/12] vkd3d-shader/hlsl: Move hlsl_new_offset_from_path_index() to hlsl_codegen.c.

Francisco Casas fcasas at codeweavers.com
Thu Jul 14 18:00:43 CDT 2022



On 14-07-22 14:54, Zebediah Figura wrote:
> On 7/14/22 06:24, Giovanni Mascellani wrote:
>> Il 08/07/22 23:28, Zebediah Figura ha scritto:
>>> Is this going to be removed eventually? Or used from hlsl_sm1 and 
>>> hlsl_sm4? In either case there doesn't seem to be a point in moving it.
>>
>> Isn't the point of the whole patch set to make so that each backend 
>> can customize the mapping path index -> register offset without 
>> letting the common code know? So what I would expect is that 
>> reg_offset will be removed and each backend will have its private 
>> version of hlsl_new_offset_from_path_index().
> 
> That's what I would have expected a priori, yes.
> 

Yep, but first we have to translate all compilation passes to index 
paths, until transform_deref_paths_into_offsets() is no longer necessary 
in hlsl_codegen.c.



More information about the wine-devel mailing list