[PATCH] programs/services: Start service dependencies.

Alexandre Julliard julliard at winehq.org
Fri Jul 15 05:38:31 CDT 2022


Dmitry Timoshkov <dmitry at baikal.ru> writes:

> Alexandre Julliard <julliard at winehq.org> wrote:
>
>> > is there anything that could be improved in this patch to make it acceptable?
>> 
>> It needs a mechanism to avoid dependency loops. Possibly trying to start
>> the parent service process first would work.
>
> I'm not sure what you mean by the parent service. The situation that I observe
> here is that the service with the missing dependency gets started by services.exe
> and that service is crashing because it apparently doesn't check for missing
> functionality. An attempt to start such a service under Windows with 'sc start'
> fails with ERROR_SERVICE_DEPENDENCY_DELETED error.

I mean the head of the dependency chain. If service 'foo' depends on
'bar' and 'bar' depends on 'foo' (possible indirectly), your code is
going to recurse forever.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list