[PATCH vkd3d 1/2] vkd3d: Delay adding a command queue to the blocked list until after the op is written.

Henri Verbeet hverbeet at gmail.com
Wed Jul 20 11:50:47 CDT 2022


On Mon, 18 Jul 2022 at 05:08, Conor McCarthy <cmccarthy at codeweavers.com> wrote:
>
> Otherwise the following sequence can occur:
> 1. A command queue is added to the blocked list during a Wait() call.
> 2. An unblocking Signal() occurs on the CPU in another thread, flushing the
>    blocked ops, but as no op has been written, the queue is removed from the
>    blocked list.
> 3. The blocked op is written.
> 3. Another op is queued and the queue is not re-added to the blocked
>    list because this only happens for the first op.

There are two "3."'s in that sequence. In a certain sense that's
fitting, but it still seems unintentional.



More information about the wine-devel mailing list