[PATCH v2 2/6] d3dx10_43: Share code for file data loading.

[Matteo Bruni]

On Thu, May 26, 2022 at 6:32 PM Piotr Caban <piotr at codeweavers.com> wrote:
>
> Signed-off-by: Piotr Caban <piotr at codeweavers.com>
> ---
>   dlls/d3dx10_43/async.c     | 39 +++++++++++++++---------
>   dlls/d3dx10_43/dxhelpers.h | 19 ++++++++++++
>   dlls/d3dx10_43/texture.c   | 62 +++++---------------------------------
>   3 files changed, 51 insertions(+), 69 deletions(-)
>   create mode 100644 dlls/d3dx10_43/dxhelpers.h
>

Sorry for the long wait.
The series looks generally good but, nevertheless, I have a few
comments (one really, a few lines below). I'm sure I can be convinced
to drop or defer those to a later point though.

> +    *data = HeapAlloc(GetProcessHeap(), 0, *size);

...

> -    *buffer = heap_alloc(*size);

It's already a mix up of plain win32 heap allocation functions and
heap_*() helpers. This patch is moving somewhat backwards in this
sense (or maybe sideways), which wouldn't be terrible but I think it
would be nice to take the occasion to move the whole dll to the
standard C heap functions, before making other changes.