[PATCH v2 0/5] MR169: user32/tests: Cleanup some tests.
zfigura at codeweavers.com
Wed Jun 1 13:55:32 CDT 2022
On 6/1/22 13:43, Rémi Bernon (@rbernon) wrote:
> On Wed Jun 1 18:36:38 2022 +0000, Stefan Dösinger wrote:
>>> it should be fixed by fixing the environment, not by skipping tests.
>> I'm not sure I agree. The testbot isn't the only environment where
>> people possibly run the tests, and someone new to the entire user32
>> thing might find environment-induced test failures a bug and not a feature.
>> That said, it would be sensible to apply different rules to d3d and
>> user32. In d3d, handling focus loss/gain is only a relatively small
>> part, whereas it is pretty central to user32.
> I honestly don't think you can expect tests to do anything meaningful if you are doing something else at the same time in the environment they run in. Maybe that can work for a few very well isolated things, but not for `user32`, and definitely not for `user32:win` / `user32:msg`.
> Even if we consider it a feature we can only at best skip tests, and the unaware user would get a seemingly successful test result, and be happy with it when most tests would have been skipped.
Is there a chance we can sidestep the issue by using a separate desktop
or window station?
More information about the wine-devel