[PATCH v2 2/5] winegstreamer: Reply with a video buffer pool to ALLOCATION queries.

Zebediah Figura zfigura at codeweavers.com
Wed Jun 1 18:03:29 CDT 2022

On 5/30/22 03:20, Rémi Bernon wrote:
> +            if (gst_query_get_n_allocation_pools(query) > 0)
> +                gst_query_set_nth_allocation_pool(query, 0, pool, info.size, 0, 0);
> +            else
> +                gst_query_add_allocation_pool(query, pool, info.size, 0, 0);

GStreamer documentation isn't exactly clear about this, but my 
understanding is that, as the sink, we are supposed to be the first 
element to add things to this query, and as such there shouldn't be any 
pools already. Have you encountered cases where that wasn't true? Or 
were you modeling this after some GStreamer code I didn't find?

FWIW, the above seems to be a common pattern for filters or source 
elements *after* receiving a query response from the sink, but that's 
not the case here.

More information about the wine-devel mailing list