[PATCH v2 0/5] MR139: winegstreamer: Implement video plane alignment for the H264 decoder.
Rémi Bernon (@rbernon)
wine at gitlab.winehq.org
Thu Jun 2 01:12:09 CDT 2022
On Wed Jun 1 23:20:29 2022 +0000, **** wrote:
> Zebediah Figura replied on the mailing list:
> ```
> On 5/30/22 03:20, Rémi Bernon wrote:
> > + if (gst_query_get_n_allocation_pools(query) > 0)
> > + gst_query_set_nth_allocation_pool(query, 0, pool,
> info.size, 0, 0);
> > + else
> > + gst_query_add_allocation_pool(query, pool, info.size,
> 0, 0);
> GStreamer documentation isn't exactly clear about this, but my
> understanding is that, as the sink, we are supposed to be the first
> element to add things to this query, and as such there shouldn't be any
> pools already. Have you encountered cases where that wasn't true? Or
> were you modeling this after some GStreamer code I didn't find?
> FWIW, the above seems to be a common pattern for filters or source
> elements *after* receiving a query response from the sink, but that's
> not the case here.
> ```
Yes, it's not clear how it is supposed to be used, and I just wanted to
make sure our pool would be prioritized in all cases.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/139#note_1497
More information about the wine-devel
mailing list