[PATCH 0/1] MR126: Draft: ddraw: Limit max texture size to fit a 16bit signed integer

Henri Verbeet hverbeet at gmail.com
Thu Jun 2 11:38:46 CDT 2022

On Thu, 2 Jun 2022 at 17:39, Fabian Maurer (@DarkShadow44)
<wine at gitlab.winehq.org> wrote:
> On Thu Jun  2 13:17:37 2022 +0000, **** wrote:
> > Henri Verbeet replied on the mailing list:
> > ```
> > On Wed, 25 May 2022 at 02:02, Fabian Maurer <wine at gitlab.winehq.org> wrote:
> > > Since ddraw propably never allowed sizes that big anyways,
> > > this should not cause any issues.
> > This seems like something it would be easy to write tests for.
> > ```
> Those tests would only work if your GPU advertises 32768x32768 textures though. Would the testbot be able to handle that?

I suspect not, even feature level 12_1 only requires 16384 as maximum
texture dimensions. But a test testing that ddraw never advertises
dwMaxTextureWidth/dwMaxTextureHeight larger than 16384 would still
pass there. You'd need such a GPU to verify the change is in fact
correct, but presumably you already did that.

More information about the wine-devel mailing list