[PATCH 2/9] mshtml/tests: Workaround use after free warnings.

Rémi Bernon wine at gitlab.winehq.org
Fri Jun 3 04:20:56 CDT 2022


From: Rémi Bernon <rbernon at codeweavers.com>

Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
 dlls/mshtml/tests/misc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/dlls/mshtml/tests/misc.c b/dlls/mshtml/tests/misc.c
index 410d24884ee..80d5283c275 100644
--- a/dlls/mshtml/tests/misc.c
+++ b/dlls/mshtml/tests/misc.c
@@ -28,6 +28,8 @@
 #include "initguid.h"
 #include "optary.h"
 
+static void (WINAPI *pSysFreeString)(BSTR);
+
 static void test_HTMLLoadOptions(void)
 {
     IHtmlLoadOptions *loadopts;
@@ -240,7 +242,7 @@ static void test_HTMLStorage(void)
     hres = IHTMLStorage_getItem(storage, key, &var);
     ok(hres == S_OK, "getItem failed: %08lx\n", hres);
     ok(V_VT(&var) == VT_NULL, "got %d\n", V_VT(&var));
-    SysFreeString(key);
+    pSysFreeString(key);
 
     hres = IHTMLStorage_getItem(storage, NULL, NULL);
     ok(hres == E_POINTER, "getItem returned: %08lx\n", hres);
@@ -298,6 +300,7 @@ static void test_HTMLStorage(void)
 START_TEST(misc)
 {
     CoInitialize(NULL);
+    pSysFreeString = (void *)GetProcAddress(GetModuleHandleA("oleaut32.dll"), "SysFreeString");
 
     test_HTMLLoadOptions();
     test_HTMLStorage();
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/180



More information about the wine-devel mailing list