[PATCH v2 2/9] mshtml/tests: Avoid using pointer value after free.

Rémi Bernon wine at gitlab.winehq.org
Mon Jun 6 01:07:27 CDT 2022


From: Rémi Bernon <rbernon at codeweavers.com>

Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
 dlls/mshtml/tests/misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mshtml/tests/misc.c b/dlls/mshtml/tests/misc.c
index 410d24884ee..72692c4915b 100644
--- a/dlls/mshtml/tests/misc.c
+++ b/dlls/mshtml/tests/misc.c
@@ -240,13 +240,13 @@ static void test_HTMLStorage(void)
     hres = IHTMLStorage_getItem(storage, key, &var);
     ok(hres == S_OK, "getItem failed: %08lx\n", hres);
     ok(V_VT(&var) == VT_NULL, "got %d\n", V_VT(&var));
-    SysFreeString(key);
 
     hres = IHTMLStorage_getItem(storage, NULL, NULL);
     ok(hres == E_POINTER, "getItem returned: %08lx\n", hres);
 
     hres = IHTMLStorage_getItem(storage, key, NULL);
     ok(hres == E_POINTER, "getItem failed: %08lx\n", hres);
+    SysFreeString(key);
 
     V_VT(&var) = 0xdead;
     hres = IHTMLStorage_getItem(storage, NULL, &var);
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/180



More information about the wine-devel mailing list