[PATCH 2/5] d2d1: Partially implement RegisterEffectFromStream().
Ziqing Hui
zhui at codeweavers.com
Mon Jun 6 22:43:15 CDT 2022
>>> + reg->info->default_input_count = input_count;
>>> + reg->info->min_inputs = input_count;
>>> + reg->info->max_inputs = input_count;
>> Is this supposed to be subproperties of an Input? Maybe we should have basic property support first, and store it there. Is min/max/default expressible in effect xml? <Input> attributes maybe?
>
> It is likely that they can be expressed in xml as properties of <Effect> like "DisplayName"/"Author", tests are still needed.
> And according to the current test, if I don't explicitly express them in xml, they will be equal to the number of <Input> nodes inside <Inputs>.
>
I did some tests today. I didn't find a way to express min/max/default input count in XML.
I tried these ways:
* Property of <Effect>:
<Effect>
...
<Property name='MinInputs' type='uint32' value='1'/>
</Effect>
* Sub property of <Inputs>:
<Effect>
...
<Inputs>
<Property name='Min' type='uint32' value='1'/>
</Inputs>
<Effect>
* Attribute of <Inputs>:
<Effect>
...
<Inputs min='1'/>
<Effect/>
Unfortunately, none of them work.
More information about the wine-devel
mailing list