[PATCH 0/7] MR195: winhttp: Abort web socket receive operations when the socket handle is closed
Hans Leidekker (@hans)
wine at gitlab.winehq.org
Tue Jun 7 07:54:04 CDT 2022
Hans Leidekker (@hans) commented about dlls/winhttp/request.c:
> return !ret;
> }
>
> +static void socket_handle_closing( struct object_header *hdr )
> +{
> + struct socket *socket = (struct socket *)hdr;
> +
> + if (socket->request->netconn->secure)
> + {
> + cancel_queue( &socket->send_q );
> + cancel_queue( &socket->recv_q );
> + }
> + if (!is_queue_empty( &socket->send_q ) || !is_queue_empty( &socket->recv_q ))
> + netconn_cancel_io( socket->request->netconn );
> +}
I doesn't make a lot of sense that async behavior depends on the connection being secure. Do we really need to replicate this?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/195#note_1639
More information about the wine-devel
mailing list