[tools 4/4] testbot/cgi: Don't pass the master columns to the list page.

[Francois Gouget]

ItemPage ignores any master column parameter that it might receive so
RedirectToList() has nothing to pass on. CollectionPage would ignore
the master column parameters anyway.
Fortunately this functionality is not used and not needed.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
This would only be needed if 2+-level hierarchies were represented with
all the corresponding intermediate *List pages. For instance in the
Job->Step case this would be JobsList -> JobDetails -> StepsList ->
StepDetails.
But that would be very cumbersome so of course the TestBot opted to
eliminate the intermediate 'step' pages entirely so that there is only
JobsList and JobDetails.
This is why we don't currently even make use of this mechanism since all
other details pages have no master column and link back to the global
list page (i.e. UserDetails links back to the full users list, not a
subset thereof, etc.).
---
 testbot/lib/ObjectModel/CGI/ItemPage.pm | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/testbot/lib/ObjectModel/CGI/ItemPage.pm b/testbot/lib/ObjectModel/CGI/ItemPage.pm
index b4d79e736..690458e3a 100644
--- a/testbot/lib/ObjectModel/CGI/ItemPage.pm
+++ b/testbot/lib/ObjectModel/CGI/ItemPage.pm
@@ -129,17 +129,7 @@ sub RedirectToList($)
 {
   my ($self) = @_;
 
-  my $Target = $self->{Collection}->GetCollectionName() . "List.pl";
-  my ($MasterColNames, $MasterColValues) = $self->{Collection}->GetMasterCols();
-  if (defined($MasterColNames))
-  {
-    foreach my $ColIndex (0..$#{$MasterColNames})
-    {
-      $Target .= ($ColIndex == 0 ? "?" : "&") . $MasterColNames->[$ColIndex] .
-                 "=" . url_escape($MasterColValues->[$ColIndex]);
-    }
-  }
-  return $self->Redirect($Target);
+  return $self->Redirect($self->{Collection}->GetCollectionName() . "List.pl");
 }
 
 sub OnAction($$)
-- 
2.30.2