[PATCH v2 0/7] MR205: Add support for HRESULT and ID3DX10ThreadPump parameters in D3DX10GetImageInfo functions

Piotr Caban (@piotr) wine at gitlab.winehq.org
Thu Jun 9 15:07:04 CDT 2022


On Thu Jun  9 19:22:54 2022 +0000, Matteo Bruni wrote:
> I'm not super thrilled by this kind of heavy macro usage, but I guess
> there's many more tests to come and I see that similar macros are used
> in many more places, so I'll shut up :sweat_smile:
> Can you fix up the formatting please? I think we want to consistently
> have no spaces around the '##' operator and a space between the '}' and
> the while keyword.
> Unfortunately I can't update your merge request myself at the moment
> (going to request access in a second) otherwise I'd have fixed it up
> myself, or at least dropped the final patch and approved the rest.
I'm not sure if such macros are really needed in d3dx tests. I will drop the macros for now and add it later (if needed).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/205#note_1772



More information about the wine-devel mailing list