[PATCH v3 0/6] MR217: windows.media.speech: ISpeechSynthesisStream stub implementation.

Bernhard Kölbl (@besentv) wine at gitlab.winehq.org
Fri Jun 10 07:40:02 CDT 2022


On Fri Jun 10 10:25:14 2022 +0000, Rémi Bernon wrote:
> I'd suggest to simply remove that racy `GetResult` check, but otherwise
> what about changing the check to `ok(hr == E_ILLEGAL_METHOD_CALL || hr
> == S_OK, ...)`, and then and putting the rest in an `if (hr ==
> E_ILLEGAL_METHOD_CALL)` block?
> Gotos are more often used to skip tests after a todo_wine, so that
> implementing the call only require to remove the todo_wine and the goto,
> but for normal control flow I think ifs are better.
Yeah, an if block sounds cleaner. I'd like to keep the check though.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/217#note_1827



More information about the wine-devel mailing list