[PATCH 0/4] MR233: win32u: Partially move raw input APIs.
Rémi Bernon (@rbernon)
wine at gitlab.winehq.org
Mon Jun 13 03:43:39 CDT 2022
Rémi Bernon (@rbernon) commented about dlls/win32u/rawinput.c:
> + wine_server_set_reply( req, msg_data, RAWINPUT_BUFFER_SIZE - rawinput->header.dwSize );
> + if (wine_server_call( req )) return ~0u;
> + next_size = reply->next_size;
> + count = reply->count;
> + }
> + SERVER_END_REQ;
> +
> + remaining = *data_size;
> + for (i = 0; i < count; ++i)
> + {
> + data->header.dwSize = remaining;
> + if (!rawinput_from_hardware_message( data, msg_data )) break;
> + if (overhead)
> + memmove( (char *)&data->data + overhead, &data->data,
> + data->header.dwSize - sizeof(RAWINPUTHEADER) );
> + data->header.dwSize += overhead;
I'd prefer either the original single hanging style, or
```C
if (overhead)
{
memmove( (char *)&data->data + overhead, &data->data,
data->header.dwSize - sizeof(RAWINPUTHEADER) );
data->header.dwSize += overhead;
}
```
rather than a double hanging line like this.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/233#note_1939
More information about the wine-devel
mailing list