[PATCH 1/5] mfplat/buffer: Fix size for IMC2/IMC4 buffers with odd height.

[Nikolay Sivov]

On 6/13/22 16:14, Giovanni Mascellani wrote:
> diff --git a/dlls/mfplat/tests/mfplat.c b/dlls/mfplat/tests/mfplat.c
> index 28b89de4b1f..8fddef8fd40 100644
> --- a/dlls/mfplat/tests/mfplat.c
> +++ b/dlls/mfplat/tests/mfplat.c
> @@ -5736,9 +5736,11 @@ static void test_MFCreate2DMediaBuffer(void)
>           { 2, 2, MAKEFOURCC('I','M','C','2'), 6, 128, 0, 384 },
>           { 4, 2, MAKEFOURCC('I','M','C','2'), 12, 128 },
>           { 2, 4, MAKEFOURCC('I','M','C','2'), 12, 128 },
> +        { 3, 5, MAKEFOURCC('I','M','C','2'), 20, 128 },
>           { 2, 2, MAKEFOURCC('I','M','C','4'), 6, 128 },
>           { 4, 2, MAKEFOURCC('I','M','C','4'), 12, 128 },
>           { 2, 4, MAKEFOURCC('I','M','C','4'), 12, 128 },
> +        { 3, 5, MAKEFOURCC('I','M','C','4'), 20, 128 },
>   
>           { 4,  2, MAKEFOURCC('I','M','C','1'),  32, 128, 2 },
>           { 4,  4, MAKEFOURCC('I','M','C','1'),  64, 128, 2 },
> @@ -5998,13 +6000,6 @@ static void test_MFCreate2DMediaBuffer(void)
>           hr = IMFMediaBuffer_Unlock(buffer);
>           ok(hr == S_OK, "Failed to unlock buffer, hr %#lx.\n", hr);
>   
> -        hr = pMFGetPlaneSize(ptr->fourcc, ptr->width, ptr->height, &length2);
> -        ok(hr == S_OK, "Failed to get plane size, hr %#lx.\n", hr);
> -        if (ptr->plane_multiplier)
> -            length2 *= ptr->plane_multiplier;
> -        ok(length2 == length, "%d: contiguous length %lu does not match plane size %lu, %u x %u, format %s.\n", i, length,
> -                length2, ptr->width, ptr->height, wine_dbgstr_an((char *)&ptr->fourcc, 4));
> -
Do we have all interesting tests cases for MFGetPlaneSize duplicated in 
other tests, to remove this one? Also if it needs to be removed 
multiplier field becomes unused.