Questions about the GitLab patch review process
alexhenrie24 at gmail.com
Mon Jun 13 21:11:23 CDT 2022
On Fri, Jun 10, 2022 at 10:13 AM Rémi Bernon <rbernon at codeweavers.com> wrote:
> On 6/10/22 17:21, Alex Henrie wrote:
> > Dear developers,
> > I have a couple of questions about how patch reviews on GitLab are
> > intended to work:
> > * Can I request a review from anyone?
> > * Does requesting a review improve the patch's chances of being accepted?
> > Thanks for your help.
> > -Alex
> Imho yes to both, especially to the second question.
> For the first question, it's probably best to request review from the
> maintainer of a module. Sometimes there isn't any and looking for
> someone knowledgeable is best.
> If there is a maintainer, they will probably be assigned by Alexandre
> anyway at some point (but it saves some effort if you do).
Thanks for the advice. I agree that requesting a review from the
person or people listed in the MAINTAINERS file would be best, but my
interests tend to lie in places that don't have a specific maintainer.
I will try to find knowledgeable contributors to review my GitLab
patches, and I hope you're right that it will speed the process along.
More information about the wine-devel