[PATCH v2 0/6] MR228: d3dx: improvements to texture creation functions

Matteo Bruni (@Mystral) wine at gitlab.winehq.org
Tue Jun 14 17:50:11 CDT 2022


Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/texture.c:
> +    }
> +
> +    out->Width = D3DX10_DEFAULT;
> +    out->Height = D3DX10_DEFAULT;
> +    out->Depth = D3DX10_DEFAULT;
> +    out->FirstMipLevel = D3DX10_DEFAULT;
> +    out->MipLevels = D3DX10_DEFAULT;
> +    out->Usage = D3DX10_DEFAULT;
> +    out->BindFlags = D3DX10_DEFAULT;
> +    out->CpuAccessFlags = D3DX10_DEFAULT;
> +    out->MiscFlags = D3DX10_DEFAULT;
> +    out->Format = D3DX10_DEFAULT;
> +    out->Filter = D3DX10_DEFAULT;
> +    out->MipFilter = D3DX10_DEFAULT;
> +    out->pSrcInfo = NULL;
> +}
Maybe init_load_info()? Separately, let's try to use consistent naming for D3DX10_IMAGE_LOAD_INFO variables in new code, like either load_info or just info.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/228#note_2066



More information about the wine-devel mailing list