[PATCH v2 0/6] MR228: d3dx: improvements to texture creation functions

Matteo Bruni (@Mystral) wine at gitlab.winehq.org
Tue Jun 14 17:50:12 CDT 2022


Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/texture.c:
> +    if (FAILED(D3DX10GetImageInfoFromMemory(data, size, NULL, &img_info, NULL)))
>          return E_FAIL;
> -    }
>      if (img_info.MiscFlags & D3D10_RESOURCE_MISC_TEXTURECUBE)
>      {
>          FIXME("Cube map is not supported.\n");
> -        if (hresult)
> -            *hresult = E_FAIL;
>          return E_FAIL;
>      }
>      if (img_info.ArraySize != 1)
>      {
> -        FIXME("img_info.ArraySize = %d\n", img_info.ArraySize);
> -        if (hresult)
> -            *hresult = E_NOTIMPL;
> +        FIXME("img_info.ArraySize = %d not supported.\n", img_info.ArraySize);
Nitpick, this changes the FIXME message introduced a couple of patches back.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/228#note_2068



More information about the wine-devel mailing list