[PATCH v2 0/6] MR228: d3dx: improvements to texture creation functions
Matteo Bruni (@Mystral)
wine at gitlab.winehq.org
Tue Jun 14 17:50:13 CDT 2022
Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/async.c:
> +{
> + return CONTAINING_RECORD(iface, struct texture_processor, ID3DX10DataProcessor_iface);
> +}
> +
> +static HRESULT WINAPI texture_processor_Process(ID3DX10DataProcessor *iface, void *data, SIZE_T size)
> +{
> + struct texture_processor *processor = texture_processor_from_ID3DX10DataProcessor(iface);
> +
> + TRACE("iface %p, data %p, size %Iu.\n", iface, data, size);
> +
> + if (processor->resource_data)
> + {
> + FIXME("called multiple times\n");
> + free(processor->resource_data);
> + processor->resource_data = NULL;
> + }
What's supposed to happen eventually?
This is okay for the time being, although it could use a nicer FIXME message (even simply capitalize at the front and period at the end).
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/228#note_2071
More information about the wine-devel
mailing list