Gitlab experiment wrapup

Huw Davies huw at codeweavers.com
Wed Jun 15 04:20:22 CDT 2022


On Tue, Jun 14, 2022 at 10:01:23PM +0200, Alexandre Julliard wrote:
> Another option would be to require the submitter to explicitly approve
> their own MR if it contains a patch written by someone else; that would
> be similar to a reviewer pushing fixups and then approving the MR.  It
> would require some mechanism to detect missing approvals though, so it
> may not be worth the trouble.

Could the (yet to be written) auto-add-reviewer script check whether
the submitter and author are different and in that case auto add the
submitter as a reviewer (as well as any other appropriate reviewers)?
Then the approval check just becomes the same as for regular
reviewers.

Huw.



More information about the wine-devel mailing list